Do not support old versions of Rails + Ruby / Prepare for 4.0.0 #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do not see anything to update in README on first glance |
|
In README, change to this Since we are MV bumping this semi regularly now with new Rails releases, I think it's reasonable to have people pin to MV. |
mullermp
reviewed
Jun 24, 2024
|
I pushed an update for this. |
|
@mullermp beat me to the punch! |
|
Some JRuby test is hanging. We can fix this in the Rspec conversion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#128 (comment)
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.